Update NextLinkOperationImplementation to support LRO rehydration #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport_lro_rehydration
fengzhou-msft
changed the title
…pport_lro_rehydration
ArthurMa1978
requested review from
allenjzhang,
m-nash,
AlexanderSher,
lirenhe and
chunyu3
as code owners
…pport_lro_rehydration
fengzhou-msft
commented
Nov 29, 2022
fengzhou-msft
commented
Nov 29, 2022
fengzhou-msft
commented
Jan 9, 2023
Comment on lines
+22
to
+23
| # TODO: temporary change to target at support_lro_rehydration branch | ||
| $baseUrl = 'https://raw.githubusercontent.com/Azure/azure-sdk-for-net/support_lro_rehydration/sdk/core/Azure.Core/src/Shared/' |
There was a problem hiding this comment.
Revert before merge.
fengzhou-msft
commented
Jan 9, 2023
…pport_lro_rehydration
…pport_lro_rehydration
…pport_lro_rehydration
fengzhou-msft
commented
Mar 1, 2023
| string id, | ||
| string? apiVersionOverride = null) | ||
| { | ||
| var lroDetails = BinaryData.FromBytes(Convert.FromBase64String(id)).ToObjectFromJson<Dictionary<string, string>>(); |
There was a problem hiding this comment.
Is there a more efficient way to encode and decode the id?
|
Follow up in #3301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2158
Description
This PR is to support the prototype in Azure/azure-sdk-for-net#32364
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?